Skip to content

CMake cleanup and fixes#1644

Merged
sirjuddington merged 3 commits into
sirjuddington:masterfrom
SteelT1:cmake-fixes-cleanup
Jan 2, 2024
Merged

CMake cleanup and fixes#1644
sirjuddington merged 3 commits into
sirjuddington:masterfrom
SteelT1:cmake-fixes-cleanup

Conversation

@SteelT1
Copy link
Copy Markdown
Contributor

@SteelT1 SteelT1 commented Dec 31, 2023

@Pedro-Beirao
Copy link
Copy Markdown
Contributor

To add to this, any reason BUILD_PK3 is not ON by default?

@sirjuddington
Copy link
Copy Markdown
Owner

I turned it off by default as I was getting sick of it rebuilding the entire pk3 every time I built SLADE during development (since I'm using cmake in windows now instead of the VS project/solution). It could probably be turned on by default if there was a way to have it only rebuild the pk3 if any files changed in dist/res but I'm not sure if that's possible

@sirjuddington sirjuddington merged commit 496d82d into sirjuddington:master Jan 2, 2024
@Wohlstand
Copy link
Copy Markdown

You may want to set the tree of files as dependencies, and have the pk3 build to be a target with pk3 file as a byproduct. I have in my projects a similar thing but with different purposes, but sense is same: source a pile of files and final file as a result of process.

@SteelT1 SteelT1 deleted the cmake-fixes-cleanup branch January 2, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The sudo make install / sudo ninja install fails because of slade.pk3 file missing

4 participants