Repository navigation
Make png optimization use Slade's cache directory. - #1819
Merged
Merged
Conversation
Person-Who-Exists
force-pushed
the
master
branch
from
June 15, 2025 17:36
308d1b5 to
7564f26
Compare
Contributor
Author
|
I should add here that this is my first time using c++ so my whole +6 -3 changes of c++ I made might not be that great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On UNIX, SLADE tried to write PNG files to the location of the optimization tools which is usually located in a directory where regular users don't have write privileges. This pr makes these PNG files get written to SLADE's cache directory.
This pr also fixes 1 miss-spell in the README.
I did not manage to test this pr on windows because I couldn't figure out how to compile SLADE on windows, although it should work because it changes one file path to a path that the rest of SLADE uses.