Fix some more papercuts #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing a wall's light level when light levels are unlinked now changes the light of the wall, rather than the sector. 3D mode also now renders light levels on walls correctly.
Otherwise some ZDoom effects, like unlinked light levels, are just quietly ignored!
This functionality already existed, but wasn't being used.
Look at these incredible benefits: - Switch to sector mode, then 3D mode. Shift-click to mass-select an area. Switch out of 3D mode, and keep the selection! - Switch to sector mode. Select some sectors that have very fine geometry. Switch to line mode, and operate on the outline with ease!
This should make `ArgsPanel::getArgValue` no longer crash when the controls haven't yet been set up. It also cleans up some of the code around `ArgsPanel::setup`, which should avoid the situation that caused the crash in the first place.
I sometimes stumble over having a selection when I think I don't, so hopefully a subtle persistent reminder will help.
The key was correctly recognized, but it was changing panning rather than scale!
This fixes awkward problems like trying to paste a 3x3 room and finding that it won't paste aligned to the grid, because the center is what snaps. The new behavior matches how regular movement works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some more small, mostly-independent things. Also includes a possible fix for the crash in #366.