Fix compiler warnings generated when compiling with -Wall flag. #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the typedef storage class specifier from the declaration of the URLPARAM_RESULT enum as this is not required and causes gcc to emit the warning "'typedef' was ignored in this declaration" when compiling with -Wall.
Correct the order of the initializer list so that gcc doesn't emit the warning "'WebServer::m_cmdCount' will be initialized after 'int WebServer::m_contentLength' when initialized here" when compiling using -Wall.
Add an additional set of brackets around the while loop condition in WebServer::printP to stop gcc emitting the warning "suggest parentheses around assignment used as truth value" when compiling using -Wall.
Convert some of the int and char variables to be unsigned int and unsigned char types. This prevents gcc generating the warnings "comparison between signed and unsigned integer expressions" and "array subscript has type 'char'", as well as having a nice side-effect of shaving 42 bytes off the compiled size when building for the Uno.
The Command prototype has a char* parameter for the URL tail, but WebServer::dispatchCommand calls this with an empty string as a parameter if there is no URL. As gcc treats empty strings as const char*s this causes a warning to be emitted when compiling using -Wall, so suppress it by explicitly casting it to char*.
unwiredben
added a commit
that referenced
this pull request
Dec 30, 2013
Fix compiler warnings generated when compiling with -Wall flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits resolve all of the warnings which were generated when compiling the current library with the
-Wallflag passed toavr-gcc. One of them also has the nice side effect of shaving 42 bytes off the compiled program size when building for the Arduino Uno.