Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation now EthernetClient equality operator is overloaded #46

Merged
merged 1 commit into from Jan 1, 2014

Conversation

Projects
None yet
2 participants
@ribbons
Copy link
Contributor

commented Jan 1, 2014

Remove comparison of m_client against NULL as this causes the following compilation error since the addition of an overload for the equality operator in arduino/Arduino@ca37de4:

Webduino/WebServer.h: In member function 'int WebServer::read()':
Webduino/WebServer.h:729: error: ambiguous overload for 'operator==' in '((WebServer*)this)->WebServer::m_client == 0'
Webduino/WebServer.h:729: note: candidates are: operator==(int, int) <built-in>
libraries\Ethernet\src/EthernetClient.h:27: note:                 virtual bool EthernetClient::operator==(const EthernetClient&)

This also initializes m_client with MAX_SOCK_NUMBER instead of 255 to make the boolean test of m_client work correctly.

Fix compile now EthernetClient == is overloaded
Remove comparison of m_client against NULL as this causes a compilation
error since arduino/Arduino@ca37de4.
Also initialize m_client with MAX_SOCK_NUMBER to make boolean test of
m_client work correctly.

unwiredben added a commit that referenced this pull request Jan 1, 2014

Merge pull request #46 from ribbons/ethernetclient-compile-error
Fix compilation now EthernetClient equality operator is overloaded

@unwiredben unwiredben merged commit 7b746b6 into sirleech:master Jan 1, 2014

@ribbons ribbons deleted the ribbons:ethernetclient-compile-error branch Jan 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.