Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
ValueStack not properly reset during application of "reduction rules" #207
When a rule transforms the value stack (rather than simply pushing values onto it) then these transformations are not always rolled back (as one would expect) when an
The tests added with the referenced commit below demonstrate the problem.
Due to the mutable nature of the value stack (which is mutable in order to avoid an allocation with every
One way could be to switch to a hybrid mutable/immutable value stack implementation, which mutates in place for the large majority of cases and only allocates when
Another solution would be to completely disallow reduction rules for