Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: fix wrong callback method #893

Merged
merged 1 commit into from Jan 22, 2019
Merged

Conversation

@jiangxin
Copy link

@jiangxin jiangxin commented Jan 22, 2019

Fix wrong callback in logger.go, and add test cases:

  1. logger.Warningln should call logger.Warnln, not logger.Warn.

  2. It's ok for logger.Print to call entry.Info, but calling entry.Print
    is better.

Signed-off-by: Jiang Xin zhiyou.jx@alibaba-inc.com

Fix wrong callback in `logger.go`, and add test cases:

1. `logger.Warningln` should call `logger.Warnln`, not `logger.Warn`.

2. It's ok for `logger.Print` to call `entry.Info`, but calling `entry.Print`
   is better.

Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
@richpoirier richpoirier merged commit 7d8d638 into sirupsen:master Jan 22, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@richpoirier
Copy link
Collaborator

@richpoirier richpoirier commented Jan 22, 2019

Good catch @jiangxin, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants