Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop x/crypto package dependency #932

Merged
merged 4 commits into from Mar 28, 2019
Merged

Drop x/crypto package dependency #932

merged 4 commits into from Mar 28, 2019

Conversation

@tandr
Copy link
Contributor

@tandr tandr commented Mar 26, 2019

Closes #928

@tandr tandr marked this pull request as ready for review Mar 26, 2019
Copy link
Collaborator

@lavoiesl lavoiesl left a comment

Beautiful

internal/terminal/terminal_check_bsd.go Outdated Show resolved Hide resolved
internal/terminal/terminal_check_unix.go Outdated Show resolved Hide resolved
@tandr tandr force-pushed the tandr:drop-crypto-2 branch from 70817fd to 9a81d9f Mar 27, 2019
@tandr
Copy link
Contributor Author

@tandr tandr commented Mar 27, 2019

Would it be possible to slap a tag on it once it is merged in? Or it is not sufficiently big change to bump it to v1.4.1 ?

@tandr tandr force-pushed the tandr:drop-crypto-2 branch from 9a81d9f to 5d8c3bf Mar 27, 2019
@lavoiesl
Copy link
Collaborator

@lavoiesl lavoiesl commented Mar 27, 2019

A patch bump would be in order, yes. I’m just waiting for someone else to review.

@dgsb
Copy link
Collaborator

@dgsb dgsb commented Mar 28, 2019

@tandr that looks good to me.

@dgsb dgsb merged commit 787e519 into sirupsen:master Mar 28, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tandr tandr deleted the tandr:drop-crypto-2 branch Mar 28, 2019
@tandr
Copy link
Contributor Author

@tandr tandr commented Mar 28, 2019

@dgsb David, would you be able to tell when do you guys expect v1.4.1 get tagged? Reason I am asking is that or I need to pull it now and then second time when you tag it, or if you expect it tomorrow or in very near future, I can just wait for it instead.

@thaJeztah
Copy link
Collaborator

@thaJeztah thaJeztah commented Apr 1, 2019

+1 on tagging a v1.4.1 for this 🤗

@dgsb
Copy link
Collaborator

@dgsb dgsb commented Apr 1, 2019

@tandr and @thaJeztah we can not yet, we do not want to make public the new terminal interface.

@tandr
Copy link
Contributor Author

@tandr tandr commented Apr 1, 2019

@dgsb added #943 to address this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants