Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Sisimai::Message faster #368

Merged
merged 36 commits into from
Feb 10, 2020
Merged

Make Sisimai::Message faster #368

merged 36 commits into from
Feb 10, 2020

Conversation

azumakuniyuki
Copy link
Member

@azumakuniyuki azumakuniyuki commented Jan 24, 2020 •
edited
Loading

  • Use Look (ahead|behind) regular expression code based on https://gist.github.com/xtetsuji/b080e1f5551d17242f6415aba8a00239 Make Sisimai::Message faster #366
  • Implement Sisimai::Message->makemap() using regular expression above.
    • Remove Sisimai::Message->takeapart (replaced with makemap)
    • Remove Sisimai::Message->headers (replaced with makemap)
  • Remove Sisimai::Order->headers
  • Remove Sisimai::Lhost->headerlist
    • And all headerlist method have been removed from Sisimai::Lhost::*, Sisimai::RFC3834 and Sisimai::ARF
  • Sisimai::Order improvement
    • Rewrite Sisimai::Order->make
    • Remove Sisimai::Order->by
    • More faster by $Subject

@coveralls
Copy link

coveralls commented Jan 24, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.09%) to 95.215% when pulling d33e7ad on make-sisimai-message-faster into d8b4fc3 on master.

azumakuniyuki
azumakuniyuki commented Feb 4, 2020
View reviewed changes
Copy link
Member Author

@azumakuniyuki azumakuniyuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make test succeeded.

lib/Sisimai/Message.pm Outdated Show resolved Hide resolved
azumakuniyuki added a commit to sisimai/rb-sisimai that referenced this pull request Feb 9, 2020
@azumakuniyuki
Import Pull-Request from sisimai/p5-sisimai#368
09ec444
@azumakuniyuki azumakuniyuki mentioned this pull request Feb 9, 2020
Merged
@azumakuniyuki azumakuniyuki merged commit 4c96d29 into master Feb 10, 2020
@azumakuniyuki azumakuniyuki deleted the make-sisimai-message-faster branch June 3, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azumakuniyuki @coveralls