Permalink
Browse files

Problem: Repository::new_named_item duplicate check on aarch64

Tests pertaining to duplicate name fail in debug mode on aarch64,
the OS error is never returned.

Solution: use FastISel instead of GlobalISel

Tracking issue has been filed with Rust:
rust-lang/rust#50516
  • Loading branch information...
yrashk committed May 7, 2018
1 parent 9a1c90d commit 38bfb95aaa5452b8fd22350655dce2a43122984f
@@ -0,0 +1,3 @@
# https://github.com/rust-lang/rust/issues/50516
[target.'cfg(all(debug_assertions, target_arch = "aarch64"))']
rustflags = ["-C", "llvm-args=-fast-isel"]
@@ -0,0 +1 @@
Problem: workaround for std::fs:create_dir not failing on existing directory on aarch64, debug
@@ -0,0 +1,5 @@
std::fs::create_dir does not fail on existing directory on aarch64, when built in debug, leading to failing tests and change in behavior (item with the same name can be created more than once). This issue has been resolved with a workaround handling this special case specifically in this configuration.
However, this is not the most beautiful solution.
Tracking issue filed with Rust: https://github.com/rust-lang/rust/issues/50516

0 comments on commit 38bfb95

Please sign in to comment.