Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

(bugfix) (v3.5.1) fix permissions of projects.list file

update-gitweb-access-list had a change recently (289b19d) that had a
side-effect of making projects.list unreadable by other userids (like
'apache' or whatever).

This makes 3.5 unusable for anyone using gitweb.  (Hence the new tag,
too, though 3.5 is only the previous commit and this is a very small
change).
  • Loading branch information...
commit 113657011053e8be475bc6a6e0f1c7e664a9a3f1 1 parent 4071623
@sitaramc authored
Showing with 2 additions and 1 deletion.
  1. +2 −1  src/triggers/post-compile/update-gitweb-access-list
View
3  src/triggers/post-compile/update-gitweb-access-list
@@ -20,7 +20,8 @@
plf=`gitolite query-rc GITWEB_PROJECTS_LIST`
[ -z "$plf" ] && plf=$HOME/projects.list
-tmpfile=`mktemp $plf.tmp_XXXXXXXX`
+# since mktemp does not honor umask, we just use it to generate a temp filename
+tmpfile=`mktemp -u $plf.tmp_XXXXXXXX`
(
gitolite list-phy-repos | gitolite access % gitweb R any | grep -v DENIED
gitolite list-phy-repos | gitolite git-config -r % gitweb\\.
Please sign in to comment.
Something went wrong with that request. Please try again.