Permalink
Browse files

prevent empty %groups being created in compiled conf

this would happen if @all was used but no actual groups were defined,
and would in turn cause a parse error on the compiled conf because it
now ends with a 'false'.

thanks to Jelle Raaijmakers
  • Loading branch information...
1 parent 72e36f3 commit b6d6260dbb8f7881f9d1a312fc26aa0e3f7d69de @sitaramc committed Nov 28, 2012
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/lib/Gitolite/Conf/Store.pm
@@ -156,7 +156,7 @@ sub new_repos {
# normal repos
my @repos = grep { $_ =~ $REPONAME_PATT and not /^@/ } sort keys %repos;
# add in members of repo groups
- map { push @repos, keys %{ $groups{$_} } } grep { /^@/ } keys %repos;
+ map { push @repos, keys %{ $groups{$_} } } grep { /^@/ and $_ ne '@all' } keys %repos;
for my $repo ( @{ sort_u( \@repos ) } ) {
next unless $repo =~ $REPONAME_PATT; # skip repo patterns

0 comments on commit b6d6260

Please sign in to comment.