set umask as early as possible

sitaramc · Sep 3, 2013 · fa06a34 · fa06a34
1 parent 62fb317
commit fa06a34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/gitolite-shell b/src/gitolite-shell
@@ -92,8 +92,6 @@ sub in_ssh {
 sub main {
     my $id = shift;
 
-    umask $rc{UMASK};
-
     # set up the user
     my $user = $ENV{GL_USER} = shift @ARGV;
 

diff --git a/src/lib/Gitolite/Rc.pm b/src/lib/Gitolite/Rc.pm
@@ -90,9 +90,11 @@ unshift @{ $rc{ACCESS_1} }, 'Writable::access_1';
 # use an env var that is highly unlikely to appear in real life :)
 do $ENV{G3T_RC} if exists $ENV{G3T_RC} and -r $ENV{G3T_RC};
 
-# setup some perl/rc/env vars
+# setup some perl/rc/env vars, plus umask
 # ----------------------------------------------------------------------
 
+umask $rc{UMASK};
+
 unshift @INC, "$rc{LOCAL_CODE}/lib" if $rc{LOCAL_CODE};
 
 $ENV{PATH} = "$ENV{GL_BINDIR}:$ENV{PATH}" unless $ENV{PATH} =~ /^$ENV{GL_BINDIR}:/;