Commits on Feb 1, 2010
  1. Merge remote branch 'origin/pu'

    Sitaram Chamarty committed Feb 1, 2010
Commits on Jan 30, 2010
  1. doc/3: couple of clarifications

      - deny rules only apply to "W" ops
      - be more specific about what allows "R" to pass
    Sitaram Chamarty committed Jan 30, 2010
Commits on Jan 27, 2010
  1. easy install: two rc file update bugs fixed

    The "msysgit doesnt have 'comm'" commit (from 2 days ago), had 2 bugs:
      - (smaller) the "+++" which was part of the diff header was triggering
        a spurious rc file "new variables" warning, but there were no actual
        variables to update
      - (bigger) worse, the grep command, when there were no matches,
        coupled with the "set -e" to kill the program right there (ouch!)
    Sitaram Chamarty committed Jan 27, 2010
  2. document the "include" mechanism

    Sitaram Chamarty committed Jan 27, 2010
Commits on Jan 25, 2010
  1. (rats! msysgit doesnt have 'comm'...)

    Sitaram Chamarty committed Jan 25, 2010
  2. sshkeys-lint: new program

    run without arguments for usage
    Sitaram Chamarty committed Jan 25, 2010
  3. doc/6 revamp: minor addition

    Sitaram Chamarty committed Jan 25, 2010
Commits on Jan 23, 2010
  1. compile: allow "#" in *simple* strings

    like: config notify.ircChannel = "#foo"
    (thanks, jhelwig)
    Sitaram Chamarty committed Jan 23, 2010
Commits on Jan 22, 2010
  1. doc/6 revamp; would appreciate reviews ;-)

    Sitaram Chamarty committed Jan 22, 2010
  2. doc/3: gitweb integ; trailing slash on $projectroot

    It's not clear whether $projectroot has or does not have a trailing
    slash.  Current code assumes it does, but we need to cater for it not
    having one also.  Otherwise the final reponame ends up with a leading
    slash, once $projectroot has been stripped from the beginning of the
    full repo path.
    Sitaram Chamarty committed with Sitaram Chamarty Jan 21, 2010
Commits on Jan 17, 2010
  1. compile: disallow multiple pubkeys in one file

    The way pubkey files are handled by gitolite, this could be used by a
    repo admin to get shell access.  It's always been there as an
    undocumented emergency mechanism for an admin who lost his shell keys or
    overwrote them due to not understanding ssh well enough (and it has been
    so used at least once).
    But not any more...
    Like the @SHELL case, this reflects a shift away from treating people
    with repo admin rights as eqvt to people who have shell on the server,
    and systematically making the former lesser privileged than the latter.
    While in most cases (including my $DAYJOB) these two may be the same
    person, I am told that's not a valid assumption for others, and there've
    been requests to close this potential loophole.
    Sitaram Chamarty committed with Sitaram Chamarty Jan 15, 2010
Commits on Jan 15, 2010
  1. mention NAME-based restrictions in README

    Sitaram Chamarty committed Jan 15, 2010
  2. delegation doc: minor oops

    I know hardly anyone is using delegation, but if you find yourself
    locked out from pushing because of this one little thing, do this:
      * on your gitolite-admin clone, add the required lines per this patch,
        and commit
      * on the server, edit ~/.gitolite/conf/, and
        delete the following line
            'NAME_LIMITS' => 1
        from the entry for "gitolite-admin" (if you don't know what that
        means delete *all* such lines) and save the file
      * back on your admin repo clone, do a push
    Sitaram Chamarty committed Jan 15, 2010
Commits on Jan 14, 2010
  1. @SHELL is now $SHELL_USERS in the rc file (warning: backward compat b…

    Stop conflating the privilege to push changes to the admin repo with the
    privilege to get a shell on the server.
    Please read doc/6 carefully before upgrading to this version.  Also
    please ensure that the gitolite key is *not* your only means to get a
    command line on the server
    Sitaram Chamarty committed with Sitaram Chamarty Jan 14, 2010
Commits on Jan 13, 2010
  1. update hook: anchor refex with ^ when matching refs

    Currently, a line like
        RW  foo =   user1
    allows user1 to push any ref that contains the string refs/heads/foo.
    This includes refs like
    which is fine; that is what is intended.  (You can always use foo$
    instead of foo if you want to prevent the latter two).
        RW  refs/foo    =   user1
    Now, I don't see this as a "security risk" but the fact is that this
    allows someone to clutter your repo with junk like
    (or, with the second config line example,
    My personal advice is if you find someone doing that intentionally, you
    should probably take him out and shoot him [*], but since now *two*
    people have complained about this, here goes...
    [*]     you don't have to take him out if you don't want to
    Sitaram Chamarty committed Jan 13, 2010
Commits on Jan 10, 2010
  1. compile: support "include" definition

    Support config file including using:
    include "filename"
    If filename is not an absolute path, it is looked from the
    $GL_ADMINDIR/conf/ directory.
    For security reasons include is not allowed for fragments.
    Signed-off-by: Teemu Matilainen <>
    tmatilai committed with Sitaram Chamarty Jan 5, 2010
  2. change delegation to NAME/ style (warning: backward compat breakage)

    This is a backward incompatible change.  If you are using delegation and
    you upgrade to this version, please do the following:
      * change your gitolite.conf file to use the new syntax (see
        doc/5-delegation.mkd in this commit)
      * for each branch "foo" in the gitolite-admin repo, do this:
            # (on "master" branch)
            git checkout foo -- conf/fragments/foo.conf
      * git add all those new fragments and commit to master
      * delete all the branches on your clone and the server
            # again, for each branch foo
            git branch -D foo
            git push origin :foo
    Sitaram Chamarty committed Jan 7, 2010
Commits on Jan 9, 2010
  1. deprecation warning about old style PATH/ syntax

    (this commit will probably get reverted after a suitable period has
    elapsed and no one is likely to still be using the old syntax).
    Forgetting to change it to NAME/ after is a security issue -- you end up
    permitting stuff you don't want to!
    This commit allows the old syntax but prints a warning
    Sitaram Chamarty committed Jan 9, 2010
  2. NAME-based restrictions

    Gitolite allows you to restrict changes by file/dir name.  The syntax
    for this used "PATH/" as a prefix to denote such file/dir patterns.
    This has now been changed to "NAME/" because PATH is potentially
    While this is technically a backward-incompatible change, the feature
    itself was hitherto undocumented, and only a few people were using it,
    so I guess it's not that bad...
    Also added documentation now.
    Sitaram Chamarty committed Jan 7, 2010
Commits on Dec 30, 2009
  1. Revert "easy install: needs a minor fix to accommodate auto-vivificat…

    This reverts commit 6576e82.
    On oddball configs, where the shell key is reused as the gitolite key by
    smart( people|-alecks), the ls-remote stops the program dead, preventing
    the "git add" and "git commit" that seed the admin repo.
    This makes extra work in terms of fixing it after the fact; removing it
    makes the install go further, and all you need to do is (1) delete the
    first line from ~/.ssh/authorized_keys on the server and (2) back on the
    client do a "git clone gitolite:gitolite-admin".
    OK so it needs to be removed.  Explaining that was the easy part!  The
    hard part is explaining why removing it is harmless.
    Look at the commit tree around that commit, and see that the commit
    before that (b78a720) was partially reverted in e7e6085.  b78a720
    removed the new_repo call from compile, forcing it to happen only on
    auth, which forced this workaround for seeding the admin repo.
    Since e7e6085 reverted that part of b78a720, giving back new_repo
    functions to compile, this line of code wasn't doing any good.  QED and
    all that :)
    Sitaram Chamarty committed Dec 30, 2009
Commits on Dec 24, 2009
  1. auth: regex goof on my part

    for those not yet able to upgrade (or until I merge this into the branch
    you care about), if you have a repo called, say "bk2git", just refer to
    it as "bk2git.git" in the clone command!
    [Thanks to Mark Frazer for finding this...]
    Sitaram Chamarty committed Dec 24, 2009
  2. install transcript

    Sitaram Chamarty committed Dec 24, 2009
Commits on Dec 23, 2009
  1. document @SHELL feature, allow "info" for all,

    ...but still distinguish shell folks with a small extra line telling
    them they have shell access
    Sitaram Chamarty committed Dec 23, 2009
Commits on Dec 22, 2009
  1. easy install: minor user message change for first-time install

    Sitaram Chamarty committed Dec 22, 2009
Commits on Dec 21, 2009
  1. doc/3, conf: document @all for repos

    plus some refactoring of doc/3
    Sitaram Chamarty committed Dec 21, 2009
  2. compile: support "repo @all" definitions

    "repo @all" can be used to set permissions or configurations for all
    already defined repos.  (A repository is defined if it has permission
    rules associated, empty "repo" stanza or "@group=..." line is not enough.)
    For example to allow a backup user to clone all repos:
      # All other configuration
      repo @all
           R = backup
    Signed-off-by: Teemu Matilainen <>
    tmatilai committed with Sitaram Chamarty Dec 20, 2009
  3. minor docfix

    Sitaram Chamarty committed Dec 21, 2009
Commits on Dec 19, 2009
  1. compile: gitolite key as good as shell key for users in @SHELL group

    done by inserting a "-s" into the authkey forced command.
    (They also lose the "no-pty" restriction, for good measure!)
    Sitaram Chamarty committed Dec 19, 2009
  2. auth: (WDITOT?) allow special users to get a shell

    ".../gl-auth-command username" is the normal command that authkeys
    forces, and this prevents that key from being used to get a shell.
    We now allow the user to get a shell if the forced command has a "-s"
    before the "username", like ".../gl-auth-command -s sitaram".
    (Now that a plain "ssh gitolite" gets you a shell, there's a new "info"
    command that such privileged keys can use to get basic access info).
    Thanks to Jesse Keating for the idea!  I can't believe this never
    occurred to me before, but I guess I was so enamoured of my "innovation"
    in converting what used to be an error into some useful info I didn't
    think a bit more :/
    Sitaram Chamarty committed Dec 19, 2009
Commits on Dec 18, 2009
  1. allow '+' as valid character in user/reponames

    Sitaram Chamarty committed Dec 18, 2009
Commits on Dec 17, 2009
  1. auth: set umask when autoviv-ing repos

    Looks like I'd forgotten this when I did the autoviv code.  Repos
    created via gl-compile (when you add a new repo to the config file and
    push) worked fine, but repos created via gl-auth (when you autoviv a
    repo, wild or not) did not.
    This *should* be merged into wildrepos soon after testing; wildrepos
    will have a lot more autoviv-ing than master.
    Sitaram Chamarty committed Dec 15, 2009
  2. auth/install/pu-hook: pass ADMINDIR and BINDIR via ENV

    The admin repo's post-update hook needs to know where $GL_ADMINDIR is,
    and we had a weird way of doing that which depended on gl-install
    actually munging the hook code.
    We also always assumed the binaries are in GL_ADMINDIR/src.
    We now use an env var to pass both these values.  This removes the weird
    dependency on gl-install that the post-update hook had, as well as make
    running other programs easier due to the new $GL_BINDIR env var.
    Sitaram Chamarty committed Dec 15, 2009
Commits on Dec 13, 2009
  1. minor docfix

    Sitaram Chamarty committed Dec 13, 2009
Commits on Dec 10, 2009
  1. ssh-copy-id workaround detail plus a couple other doc fixes

    Sitaram Chamarty committed Dec 10, 2009
Commits on Dec 9, 2009
  1. document repo config support

    Sitaram Chamarty committed Dec 9, 2009