thanks to Joe Schaefer at the ASF for catching it. Note that this new pattern *may* be too restrictive -- if you're using this feature and have a problem with the new pattern please email me. See email to gitolite mailing list around this date (2010-11-28) for more details.
been meaning to do it for a while, but I got a push: http://colabti.org/irclogger/irclogger_log/git?date=2010-11-26#l622 ---- If I had been on the channel at that time I may have quoted Emerson on "consistency" just for the fun of it... ;-)
They don't work if someone calls the script for example su - gitolite -c gl-setup <key> from a directory where "gitolite" user does not have permissions (e.g. 0700), then 'cd $od' fails and we stay in gitolite's $HOME. [commit message changed by committer; author was more polite ;-)]
(we quietly do not document the 'able' adc, which is now the most "official" adc in the sense that it has a new test, t64-write-able!) other notes: fix bug in 'able' (not setting $loc)
- openssh 5.6 doesn't like "ssh user@host" with no command following it, because they changed the rules for pty allocation failure. I'm calling this a BSD compat change because BSD hit it first, but really, the "ssh -T" will eventually be needed by Linuxes also, as they start upgrading to openssh 5.6 - FreeBSD (and I presume the other BSDs also) *require* a "-t" argument to mktemp (thanks to matias for finding this). Note that on FreeBSD, -t is a prefix (the X's are taken literally, and the real random stuff gets appended to the prefix), while on Linux, it is a template (the X's are converted to random characters). Thus, on BSD you will get names like /tmp/tmp.XXXXXXXXXX.1BAEGkHm, whereas on Linux you'll get /tmp/tmp.Aq7vbdNpGp or something.
(thanks to a somewhat heated "discussion" with "abstrakt" on #git) While I don't agree with everything he said, some improvements are always possible (always, always!) in docs: - move the "conventions used" section closer to the action - add note about RPM/DEB using "gitolite" as the user, not "git" - de-emphasise multiple gitolite hosting users at the top; refer advanced users to the already present detailed section later instead - in that section, add a bit of intro, and hand-wave the inconsistency between its 2 sub-sections ;-) ---- Unrelated to the "discussion" today, someone else (running Arch? don't remember) had a system where /usr/local/bin was not in $PATH for a normal user, so I added a note about that.
but complain loudly so they stop doing this... :-)
…MESSAGE) THE COMPILED CONFIG FILE FORMAT CHANGES WITH THIS VERSION. PLEASE DO NOT MIX VERSIONS OR DOWNGRADE. Upgrading using normal gitolite upgrade means should be fine, though. Originally, we only allowed "R" and "RW" as categories of users supplied to the `setperms` command. These map respectively to "READERS" and "WRITERS" in the access rules. Now: - we prefer READERS instead of R and WRITERS instead of RW - we allow the admin to define other categories as she wishes (example: MANAGERS, TESTERS, etc). These do not have abbreviations, however, so they must be supplied in full. PLEASE, *PLEASE*, read the section in doc/wildcard-repositories.mkd for more info. This is a VERY powerful feature and if you're not careful you could mess up the ACLs nicely. Backward compat note: you can continue to use the "R" and "RW" categories when running the "setperms" command, and gitolite will internally convert them to READERS and WRITERS categories. ---- implementation notes: - new RC var called GL_WILDREPOS_PERM_CATS that is a space-sep list of the allowed categories in a gl-perms file; defaults to "R RW" if not specified - wild_repo_rights no longer returns $c, $r, $wC, where $r = $user if "R $user", $r = '@all' if "R @all", and similarly with $w and "RW". Instead it returns $c and a new hash that effectively gives the same info, but expanded to include any other valid categories (listed in GL_WILDREPOS_PERM_CATS) - consequently, the arguments that parse_acl takes also change the same way - (side note: R and RW are quietly converted to READERS and WRITERS; however, new categories that you define yourself do not have abbreviations) - setperms validates perms to make sure only allowed categories are used; however even if someone changed them behind the scenes, wild_repo_rights will also check. This is necessary in case the admin tightened up GL_WILDREPOS_PERM_CATS after someone had already setperms-d his repos. - as a bonus, we eliminate all the post-Dumper shenanigans, at least for READERS and WRITERS. Those two now look, to the compile script, just like any other usernames.
…out there" Well from now on they will be called "YourName". Even better quote from essial on #git (after literally typing in "sitaram.pub" instead of substituting his name as the instructions [in bold] tell him to do): come on you know how ubuntu users are if they see fixed width fonts inside a box they immediately copy-paste it UBUNTU USERS: I DIDN'T SAY THAT, SOMEONE ELSE DID! For details see http://colabti.org/irclogger/irclogger_log/git?date=2010-11-04#l2417 [Although, since you apparently are quite happy to use a system that default installs mono I doubt these little jibes matter to you anyway...] [idea: distribute my own pubkey with gitolite and instantly get access to every gitolite install that is not behind a firewall, anywhere in the world. No one will notice or realise what I'm doing - MUAHAHAHAHA!!!]
(actually these warnings can come in many other situations; I just noticed them when testing this adc)
- get_rights_and_owner normalises its arg1 by stripping .git if supplied, then sets the variable "repo" to the result as a side effect - new "help" adc with some default text but main purpose is to allow site local help text - other adc's refer to 'help' adc when appropriate - 'undelete' renamed to 'restore'; that's what the KDE "trashcan" program calls that operation - minor typo in sample script in documentation - main adc doc points to contrib/adc/repo-deletion.README now