Skip to content


Changes as requested #16

merged 2 commits into from

4 participants


Joe, here are the changes to CHANGES.txt and README.txt that you requested. Let me know if it's all ok.


To use the PartialPageParser, set the parser to be HTMLPageParser? Shouldn't it be PartialPageParser?


Ah... yes... I thought it would be good market research to give the GitHub code review capabilities a try.... I've updated the pull request with the fix :)


Trivial, but missing s in atlassian?


Hi Joe, still kicking?

@joewalnes joewalnes merged commit f13d79f into sitemesh:master

Thanks Joe, much appreciated! Eagerly awaiting the next version to appear in Maven. Although I understand if you might be wanting to spend time checking other PRs / issues before pushing a new release.


Hi Joe, just wondering if you might be able to provide a timeline for the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 11, 2011
  1. @jroper

    Updated changes with better descriptions of changes made, and updated…

    jroper committed
    … readme with Atlassian contributors
Commits on Nov 12, 2011
  1. @jroper

    Fixed mistake in changelog

    jroper committed
This page is out of date. Refresh to see the latest.
Showing with 14 additions and 3 deletions.
  1. +11 −3 CHANGES.txt
  2. +3 −0  README.txt
14 CHANGES.txt
@@ -1,9 +1,17 @@
-- Changes in 2.5 --
- * Single buffer parsing
- * Buffer chaining
- * PartialPageParser that only parses the <head> section of bodies
+ * Single buffer parsing. This is supported by the HTMLPageParser and the PartialPageParser, and means
+ that the parsing process will never copy the content into another buffer, thus increasing
+ performance and reducing the amount of garbage the garbage collector has to clean up after a parsing
+ * Buffer chaining. This allows multiple nested decorators (for example, using the JSP tags) to not
+ need to rebuffer or reparse the HTML of the chained buffer.
+ * PartialPageParser that only parses the <head> section of bodies. This is a very high performance
+ buffer for simple sitemesh use cases, that don't need any content extracted from the body. It stops
+ parsing as soon as it reaches the first body tag, and then scans from the end of the content to find
+ the end body tag, and treats everything in between as the body. Does not allow many of the advanced
+ features of Sitemesh to be used, such as filters and and <content> tags. To use the partial page
+ parser, set the the pageParser in sitemesh.xml to be com.opensymphony.module.sitemesh.parser.PartialPageParser
-- Changes in 2.4.2 --
3  README.txt
@@ -167,5 +167,8 @@ Thank these guys:
* Joseph Ottinger <>
* Hani Suleiman <>
* Scott Farquhar <>
+* James Roper <>
+* Matt Quail <>
+* Charles Miller <>
- Joe Walnes <>
Something went wrong with that request. Please try again.