Don't throw error if Firefox HAR export fails

Checkout #185
sitespeedio · Sep 6, 2016 · 09ce5c3 · 09ce5c3
1 parent e49ae1a
commit 09ce5c3
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,11 @@
 # Browsertime changelog
 
-ersion 1.0-beta.3 2016-09-02
+UNRELEASED
+-------------------------
+### Changed
+* If the Firefox HAR Export plugin fails, don't throw an exception, just log and skip creating a HAR. Lets see if we can make a use case so this can be fixed in the plugin.
+
+version 1.0-beta.3 2016-09-02
 -------------------------
 ### Fixed
 * Query parameters in HAR files from Chrome are now correct

diff --git a/lib/core/engineDelegate/firefoxDelegate.js b/lib/core/engineDelegate/firefoxDelegate.js
@@ -64,8 +64,8 @@ class FirefoxDelegate {
       this.index++;
     })
     .catch((e) => {
-      log.error('Couldn\'t generate the HAR from Firefox from the HAR Export Trigger.');
-      throw e
+      log.error('Couldn\'t generate the HAR from Firefox from the HAR Export Trigger.' + e);
+      // this bug needs to be fixed in HAR Export plugin
     });
   }