Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If element not found, log to the console (not error) #775

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
1 participant
@soulgalore
Copy link
Member

soulgalore commented Feb 15, 2019

We used to log as an error but that works bad if you are tracking a
element that someties are there and sometimes not (like a banner)
becasue it created an error entry in sitespeed.io that makes it hard
to alert on console errors.

If element not found, log to the console (not error)
We used to log as an error but that works bad if you are tracking a
element that someties are there and sometimes not (like a banner)
becasue it created an error entry in sitespeed.io that makes it hard
to alert on console errors.

@soulgalore soulgalore merged commit 5d4ed5a into master Feb 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soulgalore soulgalore deleted the log-as-info branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.