Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL / Alias Suggestion #2296

Closed
banuady opened this Issue Feb 7, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@banuady
Copy link

banuady commented Feb 7, 2019

This is a suggestion, not necessarily an issue:

Inside the report, the full URLs are provided in sections like Pages (table) or Page Summary. In case of a very large URL, it will look better to have the "Alias" provided in the script instead of the full URL.
Another advantage would be to easily match the generated report with Grafana Dashboard.

@soulgalore

This comment has been minimized.

Copy link
Member

soulgalore commented Feb 7, 2019

Yeah I totally agree, I didn't had the time to add it before the first release but I totally agree, let me fix that for the next release.

soulgalore added a commit that referenced this issue Feb 7, 2019

@soulgalore

This comment has been minimized.

Copy link
Member

soulgalore commented Feb 7, 2019

I've fixed it for the page summary and individual page, need to do it for the "Pages" table before releasing it.

soulgalore added a commit that referenced this issue Feb 7, 2019

Use alias from Browsertime (if availible) #2296 (#2297)
* Use alias from Browsertime (if availible) #2296

* Use alias in table
@soulgalore

This comment has been minimized.

Copy link
Member

soulgalore commented Feb 7, 2019

Merged and will release in 8.3.0.

@banuady

This comment has been minimized.

Copy link
Author

banuady commented Feb 11, 2019

Thanks, Peter. This looks fine in 8.3.0

@soulgalore

This comment has been minimized.

Copy link
Member

soulgalore commented Feb 12, 2019

Great, I will update the docs later today.

@soulgalore soulgalore closed this Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.