Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Tags and message handling for annotations #2614

Closed
soulgalore opened this issue Sep 3, 2019 · 0 comments
Closed

Refactor: Tags and message handling for annotations #2614

soulgalore opened this issue Sep 3, 2019 · 0 comments

Comments

@soulgalore
Copy link
Member

Today we have almost duplicated code for creating the annotation message/tags for InfluxDB/Graphite and Grafana. We have special handling if we run on WebPageTest (specific tags), that logic lives in all three plugins today, I think we can do that smarter so most of the annotation is created in a couple of utility functions instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant