Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra guard for missing CPU data #2312

Merged
merged 1 commit into from Feb 13, 2019

Conversation

Projects
None yet
1 participant
@soulgalore
Copy link
Member

commented Feb 13, 2019

This will not fix the original problem but at least make sure
we don't fail. #2310

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/master/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

Please describe your pull request and tell us the fix #

Thank you for making sitespeed.io even better!

Extra guard for missing CPU data
This will not fix the original problem but at least make sure
we don't fail. #2310

@soulgalore soulgalore merged commit 427d28f into master Feb 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@soulgalore soulgalore deleted the extra-guard-for-cpu-data branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.