Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coach table colouring. Resolves #871 #2317

Merged
merged 1 commit into from Feb 16, 2019

Conversation

Projects
None yet
2 participants
@fholzer
Copy link
Contributor

fholzer commented Feb 15, 2019

Your checklist for a pull request to sitespeed.io

Please review the guidelines for contributing to this repository.

  • I'm making a big change or adding functionality so I've already opened an issue proposing the change to other contributors, so I got feedback on the idea before took the time to write precious code
  • Check that your change/fix has corresponding unit tests (if applicable)
  • Squash commits so it looks sane
  • Update the documentation https://github.com/sitespeedio/sitespeed.io/tree/master/docs in another PR
  • Verify that the test works by running npm test and test linting by npm run lint

Description

Fixes #871

As some advice has 100% score, filtering on the each line was necessary to get accurate even/odd classes.

@soulgalore soulgalore merged commit c382019 into sitespeedio:master Feb 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@soulgalore

This comment has been minimized.

Copy link
Member

soulgalore commented Feb 16, 2019

Woho thanks @fholzer !!

@fholzer fholzer deleted the fholzer:fix-871 branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.