fix potentially devastating bug related to deleted experiments

sixpack · May 17, 2013 · b3b5049 · b3b5049
1 parent 8d6933c
commit b3b5049
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/sixpack/models.py b/sixpack/models.py
@@ -168,7 +168,7 @@ def delete(self):
         pipe.delete(_key('e:{0}'.format(self.name)))
 
         # Consider a 'non-keys' implementation of this
-        keys = self.redis.keys('*{0}*'.format(self.rawkey()))
+        keys = self.redis.keys('*:{0}:*'.format(self.name))
         for key in keys:
             pipe.delete(key)
 

diff --git a/sixpack/test/experiment_model_test.py b/sixpack/test/experiment_model_test.py
@@ -82,6 +82,16 @@ def test_delete(self):
         with self.assertRaises(ValueError):
             Experiment.find('delete-me', self.redis)
 
+    def test_leaky_delete(self):
+        exp = Experiment('delete-me-1', self.alternatives, self.redis)
+        exp.save()
+
+        exp2 = Experiment('delete', self.alternatives, self.redis)
+        exp2.save()
+
+        exp2.delete()
+        exp3 = Experiment.find('delete-me-1', self.redis)
+        self.assertEqual(exp3.get_alternative_names(), self.alternatives)
     def test_archive(self):
         self.assertFalse(self.exp_1.is_archived())
         self.exp_1.archive()