Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how plankton dynamics is set #111

Closed
gustavdelius opened this issue Sep 22, 2019 · 0 comments · Fixed by #124
Closed

Change how plankton dynamics is set #111

gustavdelius opened this issue Sep 22, 2019 · 0 comments · Fixed by #124
Assignees
Labels
bug core Issue relates to the mizer core minor effort Resolving this issue will involve a minor effort
Milestone

Comments

@gustavdelius
Copy link
Member

Currently the function that is used to project the plankton abundance forward by one time step is stored in the @plankton_dynamics slot of the MizerParams object as a function. This leads to problems when the params object is shared with others, see #91 . We should therefore change to saving the name of the function instead of the function itself. Presumably it would then also be a good idea to change the plankton_dynamics argument to the setPlankton() function to a string rather than a function.

@gustavdelius gustavdelius added bug core Issue relates to the mizer core minor effort Resolving this issue will involve a minor effort labels Sep 22, 2019
@gustavdelius gustavdelius added this to the Version 1.1 milestone Sep 22, 2019
@gustavdelius gustavdelius self-assigned this Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core Issue relates to the mizer core minor effort Resolving this issue will involve a minor effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant