Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up use of @A and @sc slots #217

Open
2 tasks
gustavdelius opened this issue Aug 27, 2021 · 0 comments
Open
2 tasks

Clean up use of @A and @sc slots #217

gustavdelius opened this issue Aug 27, 2021 · 0 comments
Milestone

Comments

@gustavdelius
Copy link
Member

There are some weird things in the code that made sense at the time they were introduced but need to be either documented or removed:

  • The @A slot was originally intended to hold the observed biomasses of the species. This is now in the species_params data frame in the biomass_observed column. Now the @A slot is still used to determine whether a species is a background species. This too should be moved to the species_params data frame.
  • The @sc slot plays an undocumented role in adjustBackgroundSpecies(), by holding the desired total fish spectrum. I am sure this can be handled more transparently.
@gustavdelius gustavdelius added this to the Version 3.0 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant