Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support running tests on php70 #2

Merged
merged 5 commits into from
Aug 16, 2020
Merged

Support running tests on php70 #2

merged 5 commits into from
Aug 16, 2020

Conversation

sj-i
Copy link
Owner

@sj-i sj-i commented Aug 16, 2020

  • modify tests to run on PHP 7.0+
  • remove phpcs and psalm from require-dev and change to use tools in shivammathur/setup-php at CI
  • separate coverage reports to another workflow

@sj-i
support running tests on PHP 7.0
b5aedf9 
remove phpcs and psalm from require-dev and change to use tools in shivammathur/setup-php
@sj-i
remove --do-not-cache-result from CI settings
f4560d1 
the option is not supported by phpunit 6.5 so the test on CI fails if it is used
@sj-i
trying to fix test on PHP 7.2 and PHP 7.3
e1ed240
@sj-i
remove the leftover from the previous commit
3d1bc21
@sj-i
separate coverage reports on CI
7b8324c
@github-actions
Copy link

Pull Request Test Coverage Report for Build 210900819

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 209983172: 0.0%
Covered Lines: 8
Relevant Lines: 8
💛 - Coveralls

@sj-i sj-i merged commit bd78299 into master Aug 16, 2020
@sj-i sj-i deleted the support-running-tests-on-php70 branch August 16, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sj-i