metrics 3.0.0 is available #19

Closed
miner opened this Issue Jul 23, 2013 · 7 comments

2 participants

@miner

It looks like there are major changes in Metrics v3.0.0. That makes the current Metrics documentation confusing for metrics-clojure users. If you want to link to the Metrics 2.2.0 doc (corresponding to metrics-clojure), there's a copy archived here:

http://web.archive.org/web/20120925003800/http://metrics.codahale.com/manual/core/

@michaelklishin
Collaborator

Upgrading is a good idea but doesn't seem to be trivial. Do you use Metrics docs often? Anything major missing from metrics-clojure's own docs?

@miner

I'm new to Metrics and metrics-clojure so mostly I was just trying understand the code. The immediate concern I had was the global nature of Metrics/defaultRegistry. I was more confused when I looked at the latest Metrics doc until I realized that metrics-clojure was based on v2.2. A link to the old Metrics doc might help someone else who's trying to understand the Clojure code.

As far as the upgrade to Metrics v3.0 goes, it sounds like a bit of work. I assume there are improvements but I don't have any direct knowledge of the benefits versus the costs.

@michaelklishin
Collaborator

I'm looking into this. There indeed are assorted changes and some mean breaking API changes for metrics-clojure. That's why the version that uses Metrics 3.0 will be 2.0. I will report more specific findings later.

@michaelklishin
Collaborator

OK, so the biggest change of all is: there is no more Metrics/defaultRegistry. Which leaves us
with two options:

  • Require an explicit argument, which is a good thing
  • Maintain a var

Actually, there is a third option that I think will work well with the kind of API metrics-clojure core has: do both by using multiple arities for every function. I'm investigating this 3rd option, so far
it looks promising.

@michaelklishin michaelklishin self-assigned this Apr 27, 2014
@michaelklishin
Collaborator

@miner please take a look at #22.

@michaelklishin
Collaborator

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment