New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to @slack/client@4.8.0 and fix vulnerabilities #2

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
2 participants
@BGR360
Copy link
Contributor

BGR360 commented Jan 9, 2019

When I did npm install for the current HEAD of the master branch, there were 15 or so vulnerabilities, one of which required updating the slack client to a new major version. I have updated the code to work with the new slack client version.

I also updated the dev dependencies that had vulnerabilities.

I ran the mocha tests and they all passed, and ESLint is happy.

I also ran a very quick test with my own Slack workspace, and the RTM client does appear to detect incoming messages.

Please merge this as soon as possible, as I plan to update the repo to include support for the Events API (rather than RTM, for example when using free dynos on Heroku), and I would like to base it on the up-to-date fork.

@sjmelia sjmelia merged commit 412a87b into sjmelia:master Jan 9, 2019

@sjmelia

This comment has been minimized.

Copy link
Owner

sjmelia commented Jan 9, 2019

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment