Unicode in gzip archives isn’t handled correctly #2

Closed
sjmulder opened this Issue Feb 19, 2011 · 1 comment

Projects

None yet

2 participants

@sjmulder
Owner
$ cd sample/
$ node sample.js 
HELLO WORLD THIS IS A TEST STRING ���!
{ ham: { name: 'Hampus', value: 0.75 },
  egg: { name: 'Eggbert', value: 0.5 } }

The string should’ve been:

HELLO WORLD THIS IS A TEST STRING ÅÄÖ!
@deathcap

Looks like switching to NodeJS's built-in zlib module (deathcap@8685ef4) fixed this:

sample $ node sample.js
HELLO WORLD THIS IS A TEST STRING ÅÄÖ!
{ ham: { name: 'Hampus', value: 0.75 },
egg: { name: 'Eggbert', value: 0.5 } }

@sjmulder sjmulder closed this in 8685ef4 Mar 16, 2014
@sjmulder sjmulder pushed a commit that referenced this issue Oct 2, 2015
@rom1504 rom1504 update readme.md : fix #2 b1feb64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment