Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use poetry for python dependency management #113

Merged
merged 3 commits into from Jan 15, 2020
Merged

Use poetry for python dependency management #113

merged 3 commits into from Jan 15, 2020

Conversation

@sjohnson31
Copy link
Owner

sjohnson31 commented Jan 6, 2020

No description provided.

@sjohnson31 sjohnson31 force-pushed the poetry branch from c8f5c5d to e68a3cb Jan 6, 2020
@sjohnson31 sjohnson31 force-pushed the poetry branch from e68a3cb to 8e170aa Jan 6, 2020
- save_cache:
key: api-deps-v1-{{ checksum "requirements.txt" }}
key: api-deps-v1-{{ checksum "poetry.lock" }}
paths:
- venv

This comment has been minimized.

Copy link
@sburba

sburba Jan 6, 2020

Collaborator

Is this still the right path? Does poetry put the venv here?

This comment has been minimized.

Copy link
@sjohnson31

sjohnson31 Jan 6, 2020

Author Owner

Yes

This comment has been minimized.

Copy link
@sburba

sburba Jan 6, 2020

Collaborator

This log from the build makes me think otherwise:
Creating virtualenv ttbud-zxzmhbhl-py3.8 in /home/circleci/.cache/pypoetry/virtualenvs

api/pyproject.toml Show resolved Hide resolved
api/pyproject.toml Outdated Show resolved Hide resolved
api/Dockerfile Show resolved Hide resolved
@sburba
sburba approved these changes Jan 6, 2020
- save_cache:
key: api-deps-v1-{{ checksum "requirements.txt" }}
key: api-deps-v1-{{ checksum "poetry.lock" }}
paths:
- venv

This comment has been minimized.

Copy link
@sburba

sburba Jan 6, 2020

Collaborator

This log from the build makes me think otherwise:
Creating virtualenv ttbud-zxzmhbhl-py3.8 in /home/circleci/.cache/pypoetry/virtualenvs

@sjohnson31 sjohnson31 force-pushed the poetry branch 5 times, most recently from be977c0 to 526e6c4 Jan 15, 2020
@sjohnson31 sjohnson31 force-pushed the poetry branch from 526e6c4 to f7826b6 Jan 15, 2020
@sburba
sburba approved these changes Jan 15, 2020
@sjohnson31 sjohnson31 merged commit 257e710 into master Jan 15, 2020
2 checks passed
2 checks passed
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: web Your tests passed on CircleCI!
Details
@sjohnson31 sjohnson31 deleted the poetry branch Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.