Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search scroll #179

Closed
wants to merge 1 commit into from
Closed

Fix search scroll #179

wants to merge 1 commit into from

Conversation

@sjohnson31
Copy link
Owner

sjohnson31 commented Feb 8, 2020

No description provided.

@@ -43,9 +43,6 @@ def __init__(self, room_store: RoomStore):
self._rooms = {}
self.room_store = room_store

def valid_previous_rooms(self) -> list:

This comment has been minimized.

Copy link
@sburba

sburba Feb 8, 2020

Collaborator

This change shouldn't be a part of this PR

This comment has been minimized.

Copy link
@sburba

sburba Feb 8, 2020

Collaborator

If you merge the other PR first, this should go away, but in general it's bad form to include unrelated changes from another PR in a PR

@sjohnson31 sjohnson31 force-pushed the fix_search_scroll branch from ffc528c to b26caa4 Feb 9, 2020
@sjohnson31 sjohnson31 closed this Feb 9, 2020
@sjohnson31 sjohnson31 deleted the fix_search_scroll branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.