WORLDEDIT-3524: Fix copying of certain entities in 1.11 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The abovementioned ticket incorrectly suggests both that this is an issue unique to armor stands and is a Spigot issue. In fact this issue extends to all entities which changed IDs in the 1.11 update (armor stands and pig zombies used as test cases), and is caused by WorldEdit incorrectly using the old entity IDs to create internal snapshot representations, but the new IDs to paste them. This commit changes those IDs to the new IDs to allow clipboards created in 1.11 to be successfully pasted in 1.11(+). It does not however fix the (already existing) bug that older schematics will not have these changed entities pasted correctly. This is something that needs to be addressed separately, potentially at a level common to all platforms on which WorldEdit is supported.
|
Apologies for assuming this was a spigot error. It's just happened in the past where some issue seems to have been fixed in spigot for armor stands, and frames were just not pasting because rotation tags were changed. My 1.9.4 test server is still full of armor stand and item frames from testing this, although I never figured out what was wrong with armor stands at that time. http://i.imgur.com/mQMbuXq.png http://i.imgur.com/AiKviwi.png As for old schematics - yea that is a problem with not just entities. There are now various standards of storing block id mappings and worldedit still doesn't support any of them. Adding backward compat for entity ids as well is going to be a mess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The abovementioned ticket incorrectly suggests both that this is an issue unique to armor stands and is a Spigot issue. In fact this issue extends to all entities which changed IDs in the 1.11 update (armor stands and pig zombies used as test cases), and is caused by WorldEdit incorrectly using the old entity IDs to create internal snapshot representations, but the new IDs to paste them. This commit changes those IDs to the new IDs to allow clipboards created in 1.11 to be successfully pasted in 1.11(+). It does not however fix the (already existing) bug that older schematics will not have these changed entities pasted correctly. This is something that needs to be addressed separately, potentially at a level common to all platforms on which WorldEdit is supported.