Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/skale 215 safemath #86

Merged
merged 5 commits into from Feb 13, 2020

Conversation

yavrsky
Copy link
Contributor

@yavrsky yavrsky commented Feb 11, 2020

No description provided.

Copy link
Contributor

@payvint payvint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #86 into feature/SKALE-1642-delegation will increase coverage by 0.34%.
The diff coverage is 93.33%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/SKALE-1642-delegation      #86      +/-   ##
=================================================================
+ Coverage                          86.94%   87.28%   +0.34%     
=================================================================
  Files                                 34       34              
  Lines                               2413     2462      +49     
  Branches                             307      311       +4     
=================================================================
+ Hits                                2098     2149      +51     
+ Misses                               315      313       -2
Impacted Files Coverage Δ
contracts/ECDH.sol 96.29% <ø> (-0.05%) ⬇️
contracts/delegation/TokenState.sol 97.84% <100%> (-0.08%) ⬇️
contracts/Permissions.sol 100% <100%> (ø) ⬆️
contracts/ManagerData.sol 100% <100%> (ø) ⬆️
contracts/SkaleManager.sol 97.58% <100%> (+0.03%) ⬆️
contracts/MonitorsData.sol 100% <100%> (ø) ⬆️
contracts/delegation/Distributor.sol 100% <100%> (ø) ⬆️
contracts/delegation/TokenSaleManager.sol 100% <100%> (ø) ⬆️
contracts/NodesData.sol 100% <100%> (ø) ⬆️
contracts/SkaleToken.sol 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b924e5...f85950c. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #86 into feature/SKALE-1642-delegation will increase coverage by 0.34%.
The diff coverage is 93.33%.

Impacted file tree graph

@@                        Coverage Diff                        @@
##           feature/SKALE-1642-delegation      #86      +/-   ##
=================================================================
+ Coverage                          86.94%   87.28%   +0.34%     
=================================================================
  Files                                 34       34              
  Lines                               2413     2462      +49     
  Branches                             307      311       +4     
=================================================================
+ Hits                                2098     2149      +51     
+ Misses                               315      313       -2
Impacted Files Coverage Δ
contracts/ECDH.sol 96.29% <ø> (-0.05%) ⬇️
contracts/delegation/TokenState.sol 97.84% <100%> (-0.08%) ⬇️
contracts/Permissions.sol 100% <100%> (ø) ⬆️
contracts/ManagerData.sol 100% <100%> (ø) ⬆️
contracts/SkaleManager.sol 97.58% <100%> (+0.03%) ⬆️
contracts/MonitorsData.sol 100% <100%> (ø) ⬆️
contracts/delegation/Distributor.sol 100% <100%> (ø) ⬆️
contracts/delegation/TokenSaleManager.sol 100% <100%> (ø) ⬆️
contracts/NodesData.sol 100% <100%> (ø) ⬆️
contracts/SkaleToken.sol 100% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b924e5...f85950c. Read the comment docs.

@yavrsky yavrsky merged commit 5f65668 into feature/SKALE-1642-delegation Feb 13, 2020
@yavrsky yavrsky deleted the feature/SKALE-215-safemath branch February 13, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants