Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add support for zeus to vroom #28

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
7 participants

I've added a check to see if you have a base zeus.json in the root of your project. If you do it will turn off bundle exec and run the tests using zeus.

Let me know what you think?

Thanks,
Carl.

Collaborator

charlietanksley commented Oct 16, 2012

Hey @carlwoodward! Thanks for this. 😄 Can you add documentation for this feature?

Hi @charlietanksley thanks for replying. Sorry its taken so long for me to come back to you. I need to change the way this one works and I can add some documentation. I'll come back to you asap.

Collaborator

charlietanksley commented Dec 6, 2012

No worries. It took me longer to respond to you, I think. :)

Just want to say that I'm looking forward to this pull request being merged. 👍

Hi Charlie,

I've added some short documentation around zeus. I'd really like to make vroom check to see if zeus is running before it executes but my vim skills are lacking.

Thanks,
Carl.

@aaronjensen aaronjensen commented on the diff Dec 16, 2012

autoload/vroom.vim
@@ -233,6 +241,12 @@ function s:IsUsingBinstubs()
endif
endfunction
+function s:IsUsingZeus()
+ if g:vroom_use_zeus
@aaronjensen

aaronjensen Dec 16, 2012

Contributor

I think you can just add && filereadable(".zeus.sock") and it will only add it if zeus is actualy running.

@carlwoodward

carlwoodward Dec 16, 2012

I tried to add this in, but the dependencies on bundler are a bit more complex than I thought. Maybe we could have this as a different pull request?

@aaronjensen

aaronjensen Dec 17, 2012

Contributor

i'm not sure i follow, what happened when you added it?

@carlwoodward

carlwoodward Dec 20, 2012

I needed to change the way the bundler interaction works because I would want it to fail silently on zeus. So I started doing that but I had issues with it changing the overall flow of vroom. I'm happy to do that but I think that would become a much bigger request. I might be getting it totally wrong though, would you be able to put together a version that works the way you are thinking?

@aaronjensen

aaronjensen Dec 21, 2012

Contributor

This is all I do:

let g:vroom_spec_command = 'zeus rspec '

If you want to get clever you can do:

let g:vroom_spec_command = '`[ -e .zeus.sock ] && echo zeus` rspec '

That'll only run zeus if .zeus.sock is found.

On Thursday, December 20, 2012 at 2:59 PM, Carl Woodward wrote:

In autoload/vroom.vim:

@@ -233,6 +241,12 @@ function s:IsUsingBinstubs() > endif > endfunction > > +function s:IsUsingZeus() > + if g:vroom_use_zeus
I needed to change the way the bundler interaction works because I would want it to fail silently on zeus. So I started doing that but I had issues with it changing the overall flow of vroom. I'm happy to do that but I think that would become a much bigger request. I might be getting it totally wrong though, would you be able to put together a version that works the way you are thinking?


Reply to this email directly or view it on GitHub (https://github.com/skalnik/vim-vroom/pull/28/files#r2483737).

@Soliah

Soliah Mar 6, 2013

If I try this, bundler complains that zeus isn't part of the Gemfile. Does zeus execute this command behind bundle exec? The recommended method of running zeus is to not run it with bundler but install it outside of your Gemfile.

Soliah commented Dec 17, 2012

This doesn't work with Cucumber. Can an option for Cucumber be added too?

Soliah commented Dec 17, 2012

Setting let g:vroom_cucumber_path = 'cucumber ' made this work for me.

Collaborator

charlietanksley commented Jan 2, 2013

I haven't forgotten about this. 😄 I just need to look at it more carefully before I merge it in, and I haven't had time with the holidays. I'll take a look at it this week. Sorry for dragging my feet, and thanks for the contribution, @carlwoodward!

@charlietanksley thanks for the update. Based on @aaronjensen has said I'm not even sure if what I have done is actually correct so I would be really grateful if you could look at if it is the right implementation.

Thanks,
Carl.

Collaborator

charlietanksley commented Jan 31, 2013

@carlwoodward, Sorry for the delay. To be honest, your admission that you aren't quite sure about how you implemented it makes me nervous. 😄 I'm no VimL guru (I have to squint pretty hard to make it make sense to me!), so I have a hard time telling exactly how changes are going to pan out. Have you been using the code as it is in this pull request? Does it work as you would expect?

Also, do you just run this plain, or do you bundle exec it or use binstubs? Does that work as expected?

@kalbasit kalbasit added a commit to kalbasit/vim-vroom that referenced this pull request Mar 1, 2013

@kalbasit kalbasit Add Zeus support, smartly decide to use bundler or zeus 040b450

@kalbasit kalbasit added a commit to kalbasit/vim-vroom that referenced this pull request Mar 1, 2013

@kalbasit kalbasit Do not use color flags if running within zeus 71aa558

@kalbasit kalbasit added a commit to kalbasit/vim-vroom that referenced this pull request Mar 13, 2013

@kalbasit @kalbasit kalbasit + kalbasit Add Zeus support, smartly decide to use bundler or zeus 51016ef
Contributor

kalbasit commented Apr 9, 2013

Please close this, #35 already merged

@skalnik skalnik closed this Apr 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment