From 3482c64df021ad16951c3264fc28ddbb0abc1cb8 Mon Sep 17 00:00:00 2001 From: Dimitar Dimitrov Date: Fri, 21 Oct 2022 12:25:31 +0300 Subject: [PATCH 1/2] Remove exception notifications over email Since these sites are no longer in active development and are fairly stable, these notifications are more noise than anything useful. Exceptions usually occur while folks attempt to exploit the site with sending broken/erroneous payloads, which is not particularly interesting. Exceptions will continue to be logged to the production.log file and can be examined on demand. Should this functionality be needed, it must be introduced conditionally, configured in the per-course-edition files. --- Gemfile | 4 ---- config/environments/production.rb | 6 ------ 2 files changed, 10 deletions(-) diff --git a/Gemfile b/Gemfile index 323309b9..c80ae4e3 100644 --- a/Gemfile +++ b/Gemfile @@ -38,10 +38,6 @@ gem 'sinatra', require: false # See https://stackoverflow.com/a/60491254/75715 gem 'bigdecimal', '1.3.5' -group :production do - gem 'exception_notification' -end - group :assets do gem 'sass-rails', '~> 4.0' gem 'sass', '~> 3.2.0' diff --git a/config/environments/production.rb b/config/environments/production.rb index 32400fdf..ab09d27d 100644 --- a/config/environments/production.rb +++ b/config/environments/production.rb @@ -72,12 +72,6 @@ config.action_mailer.smtp_settings = config.smtp_settings.symbolize_keys config.action_mailer.default_url_options = {host: config.course_domain} - config.middleware.use ExceptionNotification::Rack, email: { - email_prefix: '[ERROR] ', - sender_address: "Exception Notifier <#{config.course_email}>", - exception_recipients: [config.course_email] - } - # Eager load config.eager_load = true end From a97661f13537854d2b8d7de91f51dc33e9e1c8eb Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 21 Oct 2022 09:29:27 +0000 Subject: [PATCH 2/2] Bump rack-protection from 1.5.3 to 1.5.5 Bumps [rack-protection](https://github.com/sinatra/sinatra) from 1.5.3 to 1.5.5. - [Release notes](https://github.com/sinatra/sinatra/releases) - [Changelog](https://github.com/sinatra/sinatra/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinatra/sinatra/commits) Signed-off-by: dependabot[bot] --- Gemfile.lock | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 9ffac4b1..61618e31 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -115,9 +115,6 @@ GEM mail (~> 2.2) erubis (2.7.0) eventmachine (1.0.8) - exception_notification (4.1.1) - actionmailer (>= 3.0.4) - activesupport (>= 3.0.4) execjs (2.7.0) factory_girl (4.5.0) activesupport (>= 3.0.0) @@ -211,7 +208,7 @@ GEM slop (~> 3.4) racc (1.5.2) rack (1.6.13) - rack-protection (1.5.3) + rack-protection (1.5.5) rack rack-test (0.6.3) rack (>= 1.0) @@ -389,7 +386,6 @@ DEPENDENCIES diff-lcs draper email_spec - exception_notification factory_girl_rails faker guard