Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58: Basic support for GitLab #74

Merged
merged 7 commits into from Jun 6, 2018

Conversation

Projects
None yet
1 participant
@skapral
Copy link
Owner

skapral commented Jun 6, 2018

Closes #58

Root cause of the issue

Gitlab was not supported by puzzlerbot.

Description of the changes

Added basic support for Gitlab.

Checklist

  • No classes in this PR were explicitly annotated with @Atom or @NotAtom annotation,
    or the reason for such intention is provided in PR description.

@skapral skapral changed the title Issue/58 #58: Basic support for GitLab Jun 6, 2018

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #74 into master will decrease coverage by 4.11%.
The diff coverage is 48.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #74      +/-   ##
============================================
- Coverage     70.36%   66.24%   -4.12%     
- Complexity       87       93       +6     
============================================
  Files            44       53       +9     
  Lines           388      477      +89     
  Branches         14       17       +3     
============================================
+ Hits            273      316      +43     
- Misses          112      156      +44     
- Partials          3        5       +2
Impacted Files Coverage Δ Complexity Δ
...al/puzzler/gitlab/config/Cp_GITLAB_AUTH_TOKEN.java 0% <0%> (ø) 0 <0> (?)
...kapral/puzzler/gitlab/itracker/ItGitlabIssues.java 0% <0%> (ø) 0 <0> (?)
.../skapral/puzzler/gitlab/project/GitlabProject.java 0% <0%> (ø) 0 <0> (?)
...al/puzzler/gitlab/project/GprjFromGitlabEvent.java 0% <0%> (ø) 0 <0> (?)
...apral/puzzler/gitlab/location/GlapiProduction.java 0% <0%> (ø) 0 <0> (?)
...b/skapral/puzzler/gitlab/location/GlapiStatic.java 100% <100%> (ø) 3 <3> (?)
...ral/puzzler/gitlab/source/PsrcFromGitlabNotes.java 100% <100%> (ø) 1 <1> (?)
...uzzler/gitlab/text/threepars/TwPuzzlerbotUser.java 100% <100%> (ø) 1 <1> (?)
...urce/AssertPuzzleSourceProducesCertainPuzzles.java 100% <100%> (ø) 3 <0> (ø) ⬇️
...ral/puzzler/gitlab/source/PsrcFromGitlabEvent.java 77.41% <77.41%> (ø) 1 <1> (?)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa3a20b...df86b3d. Read the comment docs.

@skapral

This comment has been minimized.

Copy link
Owner Author

skapral commented Jun 6, 2018

@puzzlerbot FYI

Support for GitLab merge requests must be introduced

Subj.

#58: Introduced basic test coverage
+ fixed a small issue in AssertPuzzleSourceProducesCertainPuzzles
@skapral

This comment has been minimized.

Copy link
Owner Author

skapral commented Jun 6, 2018

@puzzlerbot FYI

Support for GitLab webhook secret must be added.

Subj.

@skapral

This comment has been minimized.

Copy link
Owner Author

skapral commented Jun 6, 2018

@puzzlerbot FYI

Protection from unpriviledged users spam through puzzlerbot must be added for GitLab integration.

Similar as in #52, but for GitLab.

@skapral skapral merged commit 8b1ee7a into master Jun 6, 2018

3 of 5 checks passed

codecov/patch 48.88% of diff hit (target 70.36%)
Details
codecov/project 66.24% (-4.12%) compared to aa3a20b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@skapral skapral deleted the issue/58 branch Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.