From 79f5403cbcdcbe017edef93d44b0d1621af8d6fb Mon Sep 17 00:00:00 2001 From: "Stanislav (Stas) Katkov" Date: Mon, 6 Jul 2020 03:06:34 +0400 Subject: [PATCH] Normalize locale string to expected format (#26) --- CHANGELOG.md | 4 ++++ lib/carriage/builder.rb | 4 ++-- lib/carriage/version.rb | 2 +- test/carriage_test.rb | 8 ++++++++ 4 files changed, 15 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e90408c..ee4c7af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/). ## [Unreleased] +## [1.3.1] +## Add +- Normalize locale to expected format + ## [1.3.0] ## Add - Code-style now adheres to standard gem diff --git a/lib/carriage/builder.rb b/lib/carriage/builder.rb index 0b811ac..f782569 100644 --- a/lib/carriage/builder.rb +++ b/lib/carriage/builder.rb @@ -19,8 +19,8 @@ def call(items, tag: nil, key_id: nil, locale: :us) params[:AssociateTag] = tag unless tag.nil? || tag.empty? params[:AWSAccessKeyId] = key_id unless key_id.nil? || key_id.empty? - - Carriage.call(locale, params) + + Carriage.call(locale.downcase.to_sym, params) end private diff --git a/lib/carriage/version.rb b/lib/carriage/version.rb index ce3a76f..86f05cc 100644 --- a/lib/carriage/version.rb +++ b/lib/carriage/version.rb @@ -1,3 +1,3 @@ module Carriage - VERSION = "1.3.0" + VERSION = "1.3.1" end diff --git a/test/carriage_test.rb b/test/carriage_test.rb index 199d47b..9177673 100644 --- a/test/carriage_test.rb +++ b/test/carriage_test.rb @@ -67,6 +67,14 @@ def test_available_locales assert Carriage.build(items, tag: TAG, locale: :in).start_with?("https://www.amazon.in") end + def test_normalize_locales + items = [{asin: "B00WR23X5I", quantity: 1}] + + assert Carriage.build(items, tag: TAG, locale: 'UK').start_with?("https://www.amazon.co.uk") + assert Carriage.build(items, tag: TAG, locale: :IN).start_with?("https://www.amazon.in") + + end + def test_verify_locale assert_raises(Carriage::Locale::NotFound) do Carriage.call(:oo, {"ASIN.1": "B00WR23X5I", "Quantity.1": 1})