New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy-load images in history view #60

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@skddc
Copy link
Owner

skddc commented Jan 26, 2018

Use IntersectionObserver to observe image elements coming into the viewport, then set the background-image source URL from a pre-filled data attribute.

skddc added some commits Jan 26, 2018

Lazy-load images in history view
Use IntersectionObserver to observe image elements coming into the
viewport, then set the background-image source URL from a pre-filled
data attribute.
@@ -1,4 +1,4 @@
import { htmlSafe } from '@ember/string';
// import { htmlSafe } from '@ember/string';

This comment has been minimized.

@galfert

galfert Jan 26, 2018

Collaborator

Looks like you forgot to remove this line.

This comment has been minimized.

@skddc

skddc Jan 26, 2018

Owner

Thanks.

@skddc

This comment has been minimized.

Copy link
Owner

skddc commented Jan 26, 2018

Rebased and merged locally.

@skddc skddc closed this Jan 26, 2018

@skddc skddc deleted the feature/history_lazy_loading branch Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment