Permalink
Browse files

dri: Emit a critical error if a named driver fails to load.

Something has gone wrong if we were asked to load a driver of a
specific name, but it failed to load for some reason. The user really
should be made aware of this, (and instructed to set LIBGL_DEBUG for
more details).

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
  • Loading branch information...
1 parent 92bef0b commit 6c9af977401ff986964d678f8870eee23c504077 @cworth-gh cworth-gh committed Feb 4, 2012
Showing with 4 additions and 0 deletions.
  1. +2 −0 src/glx/dri2_glx.c
  2. +2 −0 src/glx/dri_glx.c
View
@@ -1135,6 +1135,8 @@ dri2CreateScreen(int screen, struct glx_display * priv)
return &psc->base;
handle_error:
+ CriticalErrorMessageF("failed to load driver: %s\n", driverName);
+
if (configs)
glx_config_destroy_list(configs);
if (visuals)
View
@@ -916,6 +916,8 @@ driCreateScreen(int screen, struct glx_display *priv)
return &psc->base;
cleanup:
+ CriticalErrorMessageF("failed to load driver: %s\n", driverName);
+
if (psc->driver)
dlclose(psc->driver);
glx_screen_cleanup(&psc->base);

0 comments on commit 6c9af97

Please sign in to comment.