Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip "regionTooltip" prop cannot take multiple classes #967

Closed
noblepen8723 opened this issue Feb 15, 2023 · 2 comments
Closed

Tooltip "regionTooltip" prop cannot take multiple classes #967

noblepen8723 opened this issue Feb 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@noblepen8723
Copy link

noblepen8723 commented Feb 15, 2023

Current Behavior

When trying to style a tooltip on a button, using multiple classes on a regionTooltip prop breaks things and yields Uncaught (in promise) DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('text-sm uppercase') contains HTML space characters, which are not valid in tokens. in console.

Steps To Reproduce

<button class="btn variant-filled-primary" use:tooltip={{ content: 'Hello', regionTooltip: 'text-sm uppercase' }}>I'm a button</button>

Using a single regionTooltip class yields the expected result.

Anything else?

My apologies if I'm just making a dumb mistake here!

@noblepen8723 noblepen8723 added the bug Something isn't working label Feb 15, 2023
@endigo9740
Copy link
Contributor

endigo9740 commented Feb 15, 2023

@noblepen8723 Just FYI we're in the midst of changes to how Utility features like Tooltips work:

It's very likely these will work in a different fashion in the next release. I'll circle back on this and try to test and confirm soon. But keep an eye out for the next release.

@endigo9740
Copy link
Contributor

Please refer to: #922

As of the last couple days we've completely replaced Menus/Tooltips with a new "Popups" feature, which you can preview here:
https://skeleton-docs-git-chore-utilities-polish-pass-skeleton-labs.vercel.app/utilities/popups

Tooltips now operate much more like Menus, where the popup UI itself is created locally (like a sibling to the trigger). This means all styles can be set directly on the UI you're generating. It's a lot simpler and more intuitive. I think folks are going to enjoy it.

Given this, the issue in the original post is no longer relevant, so I'm closing this out. Expect to see these changes alongside the new release on Tuesday (US time) next week! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants