Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Removed animate and transition directives #1321

Merged

Conversation

JustBarnt
Copy link
Contributor

Before submitting the PR:

What does your PR address?

Poor performance with Autocomplete on large datasets

Please briefly describe your changes here.
Removed animate and transition directives for now.

@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 6:48pm

@endigo9740
Copy link
Contributor

endigo9740 commented Apr 13, 2023

@JustBarnt reviewing the PR, only one more thing - keep the duration prop but move it down and follow the lead for the depreciated properties like whitelist/blacklist. Be sure to alter the JSDoc comment as well.

We don't want to remove props when we can avoid it, as this would be a breaking change. It will be remain dormant, and a migration will need to occur, but this change would introduce errors in a user's app. That's something we must strive to restrict for major versions (ex: 2.x.x).

We'll then be able to remove this at some point in the future, most likely when we roll over to v2

@JustBarnt
Copy link
Contributor Author

Fantastic point. I didn't even think of this, noted to make that change when I get home tonight. Thanks!

@endigo9740
Copy link
Contributor

@JustBarnt saw the change come through. Looks good to me, unless you have anything else I'll aim to merge this tomorrow. Super appreciate the help here sir!

@endigo9740
Copy link
Contributor

@JustBarnt thanks for duration change. I think with that this is good to merge. You should be a go on: #1322

@endigo9740 endigo9740 merged commit 6ca8a63 into skeletonlabs:dev Apr 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete unresponsive with large options dataset
2 participants