Skip to content

Conversation

@Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Oct 13, 2025

Linked Issue

Closes -

Description

Implements the Toggle Group component

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

Copilot AI review requested due to automatic review settings October 13, 2025 22:35
@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2025

🦋 Changeset detected

Latest commit: d56be03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@skeletonlabs/skeleton-common Minor
@skeletonlabs/skeleton-svelte Minor
@skeletonlabs/skeleton-react Minor
skeleton Minor
@skeletonlabs/skeleton Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 13, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
www.skeleton.dev Ready Ready Preview Comment Oct 16, 2025 5:09pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
themes.skeleton.dev Skipped Skipped Oct 16, 2025 5:09pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new Toggle Group component for the Skeleton UI library, providing grouped buttons for toggling option states using Zag.js as the underlying state management.

Key Changes

  • Adds Toggle Group component implementation for both Svelte and React frameworks
  • Integrates @zag-js/toggle-group dependency for state management and accessibility
  • Provides comprehensive documentation and playground examples

Reviewed Changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds @zag-js/toggle-group dependency to the workspace catalog
packages/skeleton-common/src/classes/toggle-group.ts Defines CSS classes and styling for the toggle group component
packages/skeleton-svelte/src/components/toggle-group/* Implements Svelte version with provider pattern and anatomy components
packages/skeleton-react/src/components/toggle-group/* Implements React version with hooks and context providers
sites/skeleton.dev/src/content/docs/components/toggle-group/* Adds documentation pages for both frameworks
playgrounds/* Provides working examples for testing both implementations
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 36 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 13, 2025 22:40 Inactive
@vercel vercel bot temporarily deployed to Preview – www.skeleton.dev October 13, 2025 22:40 Inactive
Copilot AI review requested due to automatic review settings October 13, 2025 22:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 36 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copilot AI review requested due to automatic review settings October 13, 2025 22:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 35 out of 36 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 11 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 8 to 14
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'class' instead of 'className' in Svelte components to ensure styles are applied.

Suggested change
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
<BoldIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon class="size-4" />

Copilot uses AI. Check for mistakes.
Comment on lines 8 to 14
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'class' instead of 'className' in Svelte components.

Suggested change
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
<BoldIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon class="size-4" />

Copilot uses AI. Check for mistakes.
Comment on lines 8 to 14
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'class' instead of 'className' in Svelte components so the icon receives the expected styling.

Suggested change
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
<BoldIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon class="size-4" />

Copilot uses AI. Check for mistakes.
Comment on lines 11 to 17
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Svelte, use 'class' instead of 'className' to style components.

Suggested change
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
<BoldIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon class="size-4" />

Copilot uses AI. Check for mistakes.
Comment on lines 11 to 17
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
Copy link

Copilot AI Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace 'className' with 'class' in Svelte.

Suggested change
<BoldIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon className="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon className="size-4" />
<BoldIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="italic">
<ItalicIcon class="size-4" />
</ToggleGroup.Item>
<ToggleGroup.Item value="underline">
<UnderlineIcon class="size-4" />

Copilot uses AI. Check for mistakes.
…/+page.svelte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 16, 2025 16:52
@vercel vercel bot temporarily deployed to Preview – www.skeleton.dev October 16, 2025 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 16, 2025 16:52 Inactive
@vercel vercel bot temporarily deployed to Preview – overhaul.skeleton.dev October 16, 2025 16:52 Inactive
…roup/svelte/controlled.svelte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 16, 2025 16:53 Inactive
…roup/svelte/dir.svelte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 16, 2025 16:53 Inactive
…roup/svelte/default.svelte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – themes.skeleton.dev October 16, 2025 16:54 Inactive
@vercel vercel bot temporarily deployed to Preview – overhaul.skeleton.dev October 16, 2025 16:55 Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 39 out of 40 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 41 out of 42 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vercel vercel bot temporarily deployed to Preview – overhaul.skeleton.dev October 16, 2025 17:09 Inactive
@Hugos68 Hugos68 merged commit f5e61dd into main Oct 16, 2025
6 of 7 checks passed
@Hugos68 Hugos68 deleted the feat/toggle-group branch October 16, 2025 17:10
@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants