Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone aware issues #34

Merged
merged 1 commit into from Nov 21, 2019
Merged

Fix timezone aware issues #34

merged 1 commit into from Nov 21, 2019

Conversation

@mpgn
Copy link
Contributor

mpgn commented Nov 21, 2019

Because every dates should be timezone "aware" :)

This PR fix errors of timezone when the pypykatz project is compiled from an pipenv environment and the lsa minidump command throws this error:

  File "/root/.local/share/virtualenvs/minidump-pJ0wrUgQ/lib/python3.7/site-packages/asn1crypto-1.2.0-py3.7.egg/asn1crypto/core.py", line 5083, in set
    raise ValueError('Must be timezone aware')
ValueError: Must be timezone aware
    while constructing minikerberos.asn1_structs.KerberosTime
    while constructing minikerberos.asn1_structs.KrbCredInfo
Because every dates should be timezone "aware" :)

This PR fix errors of timezone when the pypykatz project is compiled from an **pipenv** environment and the lsa minidump command throws this error:
```
  File "/root/.local/share/virtualenvs/minidump-pJ0wrUgQ/lib/python3.7/site-packages/asn1crypto-1.2.0-py3.7.egg/asn1crypto/core.py", line 5083, in set
    raise ValueError('Must be timezone aware')
ValueError: Must be timezone aware
    while constructing minikerberos.asn1_structs.KerberosTime
    while constructing minikerberos.asn1_structs.KrbCredInfo
```
@skelsec skelsec merged commit 91b6c57 into skelsec:master Nov 21, 2019
@skelsec

This comment has been minimized.

Copy link
Owner

skelsec commented Nov 21, 2019

true dat.
thx for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.