Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix timezone aware issues #34
Merged
Conversation
Because every dates should be timezone "aware" :)
This PR fix errors of timezone when the pypykatz project is compiled from an **pipenv** environment and the lsa minidump command throws this error:
```
File "/root/.local/share/virtualenvs/minidump-pJ0wrUgQ/lib/python3.7/site-packages/asn1crypto-1.2.0-py3.7.egg/asn1crypto/core.py", line 5083, in set
raise ValueError('Must be timezone aware')
ValueError: Must be timezone aware
while constructing minikerberos.asn1_structs.KerberosTime
while constructing minikerberos.asn1_structs.KrbCredInfo
```
This comment has been minimized.
This comment has been minimized.
|
true dat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mpgn commentedNov 21, 2019
Because every dates should be timezone "aware" :)
This PR fix errors of timezone when the pypykatz project is compiled from an pipenv environment and the lsa minidump command throws this error: