Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix getParentSymbolMaster for SymbolMaster #487

Merged
merged 2 commits into from May 10, 2019

Conversation

@mathieudutour
Copy link
Contributor

mathieudutour commented May 3, 2019

@bohemian-coding-danger

This comment has been minimized.

Copy link
Collaborator

bohemian-coding-danger commented May 3, 2019

Warnings
⚠️

Source/dom/layers/SymbolMaster.js changed, but not:

  • 📚 its docs
  • 🧪 its tests

That's OK as long as you're refactoring.

Generated by 🚫 dangerJS against 9a995d4

@mathieudutour mathieudutour requested a review from christianklotz May 10, 2019
@mathieudutour mathieudutour merged commit 0b9abe8 into develop May 10, 2019
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@mathieudutour mathieudutour deleted the f/fix-getSymbolMasterParent-for-SymbolMaster branch May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.