Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTC feature for Micro8088 #2

Closed
wants to merge 1 commit into from
Closed

Add RTC feature for Micro8088 #2

wants to merge 1 commit into from

Conversation

spark2k06
Copy link
Contributor

  • Detect and use RTC (DS12885/7) for Micro8088

* Detect and use RTC (DS12885/7) for Micro8088
@skiselev
Copy link
Owner

Thank you for your code contribution!
I've added RTC auto-detect functionality in bd82671
using parts of your code. I haven't tested it just yet.

I would like to share some feedback considering the 8088 BIOS development, and the reason I couldn't merge your commit directly:

  • The BIOS supports multiple 80x86/80x88 configurations. And therefore it should be highly configurable at the build time. For example, do not assume that everyone is going to have an RTC or need RTC functionality. Use ifdef/endif around the optional code.
  • The machines' configurations are defined in config.inc. When adding an optional feature, it can be enabled from that file. Depending on circumstances a new machine configuration can be created, or a define can be added to an existing machine configuration.
  • The setloc macros are there for the compatibility reason: Some software (especially BIOS extensions) call BIOS entry points directly, without using interrupt instructions. Do not modify setlocs. If the modified code does not fit, it should be moved elsewhere, e.g. to the beginning of the BIOS code. All setlocs are limited to the last 8 KiB of the address space.

@skiselev skiselev closed this Sep 25, 2019
@spark2k06
Copy link
Contributor Author

spark2k06 commented Sep 26, 2019

I agree on all your annotations. I have added a new pull request taking advantage of the configuration of config.inc to facilitate the user to change CMOS_CONTROL_B_CONFIG in the RTC. Among other things, you may want to use the DSE:

#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants