Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO_JS_IGNORE_URLS is misleading #14

Open
denisvlr opened this issue Feb 13, 2015 · 1 comment
Open

SEO_JS_IGNORE_URLS is misleading #14

denisvlr opened this issue Feb 13, 2015 · 1 comment

Comments

@denisvlr
Copy link

Hi,

I ran into an issue trying to use the setting SEO_JS_IGNORE_URLS.

for each of them it checks if if url in request.path, shouldn't it be if url == request.path?

If for example you want to exclude exactly the page 'foo', you would define SEO_JS_IGNORE_URLS=['/foo'], but it would match any page containing 'foo' in the url.

Also a regex based option would be useful.

@skoczen
Copy link
Owner

skoczen commented Mar 3, 2015

Hey Denis,

I'm a bit partial to the "in" implementation, since it allows for more flexibility in matching. But I can also see it being confusing and at the least, not documented/named properly.

A regex match would also be useful, though I'd want it as an option, instead of the default (given the "oh, now you have two problems" nature of regex in most situations.)

I'd say let's hash out a better structure here that allows for more powerful matching, yet keeps simplicity for straightforward setups and backwards compatibility if we can.

Thanks for bringing this forward, and helping make django-seo-js better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants