Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration #14

Closed
michaeljoseph opened this issue Mar 26, 2014 · 6 comments
Closed

Fix configuration #14

michaeljoseph opened this issue Mar 26, 2014 · 6 comments

Comments

@michaeljoseph
Copy link

Exporting environment variables is wack.
We need a configuration file that peeps can customise.
Any objections to https://pypi.python.org/pypi/config/0.3.7 and json configs?

@skoczen
Copy link
Owner

skoczen commented Mar 26, 2014

I actually rather like exporting environment variables - it enforces that your secrets are never checked into your repo, Just Works on every platform, and makes it clear what info you're providing to the app.

I agree that there are a lot of vars to set for will, and that's annoying, but once they're set in your prod server, boxen, postactivate, etc, you're done.

What's the argument for their wack-itude?

@michaeljoseph
Copy link
Author

Ok, so, what I'm looking for is a thing I can run, to run your application.
Also envvars are cool and portable but what I'd like, is a configuration file with the stuff that I have to copy+paste from the README.
And something standard, like config?
Also, we can support both?

@skoczen
Copy link
Owner

skoczen commented Mar 26, 2014

So what I do locally is put the exports in my bin/postactivate file in the virtualenv. It's a one-time set, and then things Just Work. My commands to run will:

workon my_will
./run_will.py

Such a setup is pretty standard from what I see colleagues do in entirely different codebases, and mirrors the best-practices of a number of PAAS stacks. In this space, the biggest bot of them all, github's hubot follows the same standard. Given all that, I'm a bit resistant to add another layer of config. However, if there's a strong case for it, I'm definitely listening!

As for supporting both, I yield to the Zen of Python:

There should be one-- and preferably only one --obvious way to do it.

@michaeljoseph
Copy link
Author

Ok cool, then let's document and recommend that then?

@skoczen
Copy link
Owner

skoczen commented Mar 27, 2014

Sounds good - have a couple min this AM, so will get this and reqs pushed.

@skoczen
Copy link
Owner

skoczen commented Mar 27, 2014

Pushed, let me know if you think more documentation would be helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants