New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More freedom to mention Will #76

Merged
merged 1 commit into from Jan 19, 2015

Conversation

Projects
None yet
4 participants
@neronmoon
Copy link
Contributor

neronmoon commented Nov 17, 2014

Add ability to answer to mentions @will, @will, @will, @will and others

Update listener.py
Add ability to answer from mentions @will, @will, @will, @will and others
@neronmoon

This comment has been minimized.

Copy link
Contributor Author

neronmoon commented Nov 17, 2014

Lol. Sorry, dude :)

@skoczen

This comment has been minimized.

Copy link
Owner

skoczen commented Nov 18, 2014

@neronmoon - so, the hipchat standard is that there's one and only one way to @ mention a user, and it's case-sensitive. They even provide autocomplete to make that consistent. What's the use-case for breaking that convention?

@will at some point, I owe you beers for your patience. :)

@dpoirier

This comment has been minimized.

Copy link

dpoirier commented Nov 18, 2014

With such a short name as Will, often people don't bother using the autocomplete, they just type "@" + will and assume it'll work. I see that pretty frequently.

@wreiske

This comment has been minimized.

Copy link

wreiske commented Jan 16, 2015

+1!

@skoczen

This comment has been minimized.

Copy link
Owner

skoczen commented Jan 19, 2015

Merging this into 0.6.4!

skoczen added a commit that referenced this pull request Jan 19, 2015

Merge pull request #76 from neronmoon/patch-1
More freedom to mention Will

@skoczen skoczen merged commit d7cdd0c into skoczen:master Jan 19, 2015

@skoczen

This comment has been minimized.

Copy link
Owner

skoczen commented Jan 19, 2015

@neronmoon you've been added to the AUTHORS file based on your github profile - please submit a PR if you'd like different attribution!

@neronmoon neronmoon deleted the neronmoon:patch-1 branch Jan 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment