Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to merge setup dependencies #408

Merged
merged 7 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@ottonemo
Copy link
Collaborator

commented Dec 12, 2018

WIP to merge the requirements.txt and requirements in setup.py.

@thomasjpfan

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

The only issue blocking this is how tabulate is not in conda. Moving scikit-learn and tqdm to requirements-dev.txt and running conda install -file=requirements-dev.txt would work. Since scikit-learn depends on scipy and numpy, they will be installed. This will satisfy the requirements from setup.py.

Do we need to pin the versions of tqdm and tabulate?

@ottonemo

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 12, 2018

Can't we do the following:

conda create -n skorch-dev
pip install -r requirements.txt
pip install -r requirements-dev.txt
python setup.py install
conda install pytorch -c pytorch

I think that solves all the issues?

@ottonemo

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 12, 2018

Sorry, you also have to include the python version of course:

conda create -n skorch-dev
conda install python==3.7
pip install -r requirements.txt
pip install -r requirements-dev.txt
python setup.py install
conda install pytorch -c pytorch

@ottonemo ottonemo requested a review from benjamin-work Dec 12, 2018

@thomasjpfan

This comment has been minimized.

Copy link
Contributor

commented Dec 12, 2018

When using pip, we should enable the travis cache in the .travis.ci file:

cache:
  pip: true

ottonemo added some commits Dec 13, 2018

@benjamin-work benjamin-work merged commit 618e9be into master Dec 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ottonemo ottonemo deleted the features/merge_setup_requirements branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.