Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/include requirements in manifest #413

Merged
merged 3 commits into from Dec 17, 2018

Conversation

Projects
None yet
2 participants
@benjamin-work
Copy link
Collaborator

commented Dec 17, 2018

No description provided.

benjamin-work added some commits Dec 13, 2018

Tests pass even when fire and numpydoc are not installed.
Import fire and numpydoc library lazily in cli.py. This way, there is
no error when in helper.py when these libraries are not installed.
Include requirements* in MANIFEST.in.
Otherwise, install may fail because setup.py now reads from
requirements.txt.

@benjamin-work benjamin-work self-assigned this Dec 17, 2018

@benjamin-work benjamin-work requested a review from ottonemo Dec 17, 2018

@ottonemo

This comment has been minimized.

Copy link
Collaborator

commented Dec 17, 2018

This should resolve #412.

@ottonemo ottonemo merged commit 0918820 into master Dec 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ottonemo ottonemo deleted the fix/include-requirements-in-manifest branch Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.